Skip to content

Conversation

@aiuto
Copy link
Contributor

@aiuto aiuto commented Dec 13, 2025

  • Filter out the deps graph down from openscap, leaving things also used by python.
  • Since openscap is linux only, this will save us a lot of CI time over the next few weeks as we are moving openscape to Bazel.

This technique is unsustainable, but it will serve until we can query the build tree to see what tests need to be run.
For example, this #44079 is failing on a flakey windows installer test that is not relevant.

@aiuto aiuto added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 13, 2025
@github-actions github-actions bot added team/agent-devx short review PR is simple enough to be reviewed quickly labels Dec 13, 2025
- Filter out the deps graph down from openscap, leaving things also used by python.
- Since openscap is linux only, this will save us a lot of CI time over the next few weeks as we are moving openscape to Bazel.
- Add a dummy change to the exlcuded files as a test case.
@aiuto aiuto marked this pull request as ready for review December 13, 2025 05:56
@aiuto aiuto requested review from a team as code owners December 13, 2025 05:56
@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 76a78e01-e57e-4be2-9eda-6e63c79c4a7d

Baseline: 7e486ae
Comparison: 067b22e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.56 [-6.56, -0.56] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_metrics_sum_delta memory utilization +0.39 [+0.17, +0.61] 1 Logs
quality_gate_idle_all_features memory utilization +0.37 [+0.33, +0.40] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.14 [+0.10, +0.18] 1 Logs bounds checks dashboard
file_tree memory utilization +0.10 [+0.03, +0.16] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.31, +0.43] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [+0.00, +0.11] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.10, +0.15] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.36, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.14] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.00 [-0.23, +0.23] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.07, +0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.42, +0.42] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.10, +0.00] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.05 [-0.20, +0.11] 1 Logs
quality_gate_metrics_logs memory utilization -0.07 [-0.28, +0.14] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.17 [-0.27, -0.07] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.20 [-0.27, -0.12] 1 Logs
otlp_ingest_metrics memory utilization -0.38 [-0.53, -0.22] 1 Logs
docker_containers_memory memory utilization -0.43 [-0.51, -0.35] 1 Logs
ddot_metrics memory utilization -0.48 [-0.70, -0.26] 1 Logs
ddot_logs memory utilization -0.59 [-0.67, -0.51] 1 Logs
quality_gate_logs % cpu utilization -1.67 [-3.14, -0.21] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -3.56 [-6.56, -0.56] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aiuto aiuto changed the title Stop running windows tests on changes to openscap. [ABLD-180] Stop running windows tests on changes to openscap. Dec 13, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ea71b07

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0.06}$$ $${705.55}$$ < $${706.32}$$ $${+0.06}$$ $${172.91}$$ < $${173.81}$$
agent_deb_amd64_fips $${+0.06}$$ $${700.88}$$ < $${701.16}$$ $${-0.02}$$ $${171.85}$$ < $${172.71}$$
agent_heroku_amd64 $${+0}$$ $${327.27}$$ < $${327.69}$$ $${+0.01}$$ $${87.24}$$ < $${88.19}$$
agent_msi $${+0}$$ $${568.87}$$ < $${982.08}$$ $${+0.04}$$ $${141.79}$$ < $${143.01}$$
agent_rpm_amd64 $${+0.06}$$ $${705.53}$$ < $${706.31}$$ $${+0.04}$$ $${175.94}$$ < $${176.86}$$
agent_rpm_amd64_fips $${+0.06}$$ $${700.87}$$ < $${701.15}$$ $${+0.01}$$ $${173.96}$$ < $${174.95}$$
agent_rpm_arm64 $${+0.05}$$ $${691.19}$$ < $${691.67}$$ $${+0.06}$$ $${159.76}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0.05}$$ $${687.41}$$ < $${687.54}$$ $${+0.04}$$ $${159.22}$$ < $${160.1}$$
agent_suse_amd64 $${+0.06}$$ $${705.53}$$ < $${706.31}$$ $${+0.04}$$ $${175.94}$$ < $${176.86}$$
agent_suse_amd64_fips $${+0.06}$$ $${700.87}$$ < $${701.15}$$ $${+0.01}$$ $${173.96}$$ < $${174.95}$$
agent_suse_arm64 $${+0.05}$$ $${691.19}$$ < $${691.67}$$ $${+0.06}$$ $${159.76}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0.05}$$ $${687.41}$$ < $${687.54}$$ $${+0.04}$$ $${159.22}$$ < $${160.1}$$
docker_agent_amd64 $${+0.06}$$ $${767.88}$$ < $${768.66}$$ $${+0.03}$$ $${260.66}$$ < $${261.52}$$
docker_agent_arm64 $${+0.05}$$ $${777.81}$$ < $${778.35}$$ $${+0.03}$$ $${250.83}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0.06}$$ $${958.75}$$ < $${959.54}$$ $${+0.03}$$ $${329.29}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0.05}$$ $${957.41}$$ < $${957.95}$$ $${+0.03}$$ $${315.45}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${179.11}$$ < $${179.28}$$ $${+0}$$ $${63.24}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.58}$$ < $${196.79}$$ $${+0.01}$$ $${59.97}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0.01}$$ $${38.67}$$ < $${39.3}$$ $${+0}$$ $${14.94}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0.06}$$ $${37.3}$$ < $${37.94}$$ $${+0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0}$$ $${28.4}$$ < $${29.11}$$ $${+0}$$ $${6.82}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.89}$$ < $${30.53}$$ $${-0}$$ $${7.89}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.89}$$ < $${30.53}$$ $${-0}$$ $${7.89}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${+0}$$ $${11.13}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.36}$$ < $${40.92}$$ $${-0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.26}$$ < $${40.86}$$ $${+0}$$ $${9.7}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$

allow_failure: true

.if_windows_installer_changes: &if_windows_installer_changes
changes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea obviously, but I'm not sure it's going to work as-is because you have a duplicated changes key in the object, and from what I can see only the second one is going to be taken into account. This is confirmed by https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1292854322#L79 in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants