Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nickinhinguyen/Java-Shell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: CSC207-UofT/Java-Shell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 31 files changed
  • 2 contributors

Commits on Sep 21, 2021

  1. Added JUnit4 tests and exposed a way to reset the (singleton) file sy… 

    …stem.
    @pgries
    pgries committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    fcab8bc View commit details
    Browse the repository at this point in the history

  2. Reworked test to fail if an exception is thrown.

    @pgries
    pgries committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1b1f8ae View commit details
    Browse the repository at this point in the history

  3. JUnit4 test configuration

    @pgries
    pgries committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c17d226 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Cleaned up style, naming 

    Fixed format using Code—>Reformat Code
Eplained Java features
Added some TODOs
Created an Exception subclass to replace generic Exception
    @pgries
    pgries committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    71531a6 View commit details
    Browse the repository at this point in the history

  2. Serialized saving and loading. 

    Renamed FileSystem to VirtualFileSystem for less confusing use in dialog.

Extracted save/loadShellState methods from Save/Load.executeCommand. Wrote
alternative versions that serialize the data, which required having both the
VirtualFileSystem hierarchy and IShellState be Serializable.

Ran into a snag: in loadShellSTate, we don't have access to method main's
local variables, so we couldn't quite restore the file system yet. We'll
have to redesign.

Fixed the unnecessary catch for FileNotFoundException. It will be caught as
an IOException.
    @pgries
    pgries committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    3fdaf05 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Fixed some typos, updated config files.

    @paulgries
    paulgries committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c09d007 View commit details
    Browse the repository at this point in the history

  2. Fixed some typos, updated config files.

    @paulgries
    paulgries committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    08ae02c View commit details
    Browse the repository at this point in the history
Loading