Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Automattic/node-canvas
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Automattic/node-canvas
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: next
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 36 files changed
  • 1 contributor

Commits on Aug 17, 2025

  1. remove all font related functionality

    These changes will be reverted soon, but to the new implementation
    chearon committed Aug 17, 2025
    Configuration menu
    Copy the full SHA
    b701a5e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2025

  1. remove all SVG image related functionality

    I think this is going to have to come back in JS via canvg or
    something. librsvg is too much of a pain (tons of dependencies) and
    doesn't integrate with our fonts anyways.
    chearon committed Sep 2, 2025
    Configuration menu
    Copy the full SHA
    00c91f9 View commit details
    Browse the repository at this point in the history
  2. remove backends

    This is too much indirection. Backends have led to a few bugs by
    being confusing, and there is zero benefit to such an abstraction.
    It's only added LOC and more jumping around files to figure out
    what's happening.
    
    IIRC backends were added with the intent to have framebuffer
    backends but that never got merged because it's way out of scope.
    
    I broke the JS ctors in ce29f69
    so we got lucky and don't have to call this a breaking change.
    chearon committed Sep 2, 2025
    Configuration menu
    Copy the full SHA
    4ae26ab View commit details
    Browse the repository at this point in the history
  3. avoid integer overflow in ensureSurface

    width * height * approxBytesPerPixel was too big
    
    Zig found via ubsan
    chearon committed Sep 2, 2025
    Configuration menu
    Copy the full SHA
    fe7ec6d View commit details
    Browse the repository at this point in the history
  4. bail early when setting zero-length image source

    the pointer can actually be null in this case which triggers a
    ubsan panic
    chearon committed Sep 2, 2025
    Configuration menu
    Copy the full SHA
    b1fe25f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2025

  1. zig build!

    chearon committed Sep 4, 2025
    Configuration menu
    Copy the full SHA
    d35fb81 View commit details
    Browse the repository at this point in the history
Loading