Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/componentkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: AdamRobertsEF/componentkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 1 file changed
  • 1 contributor

Commits on Jan 15, 2017

  1. Removed Copy from Init 

    These get copied anyway.
    Adam Roberts committed Jan 15, 2017
    Configuration menu
    Copy the full SHA
    c422820 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2017

  1. Changed copy to strong and added assign for readablity 

    NSStrings aren’t mutable, using copy wastes memory, especially if two
instances of Quote use the same values for any of the NSString objects.
    Adam Roberts committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    f21a7dc View commit details
    Browse the repository at this point in the history

  2. Revert "Changed copy to strong and added assign for readablity" 

    This reverts commit f21a7dc.
    Adam Roberts committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    6b49869 View commit details
    Browse the repository at this point in the history

  3. Modified so that only NSMutableStrings are copied. 

    NSStrings are retained.
    Adam Roberts committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    fb1db58 View commit details
    Browse the repository at this point in the history
Loading