Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mages/ChainLadder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: 00mathieu/ChainLadder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on May 21, 2015

  1. Update Triangles.R 

    Changed from ncol to nrow when defining the 'upper' triangle. This is because if triangle has more rows than cols, then the na.rm=TRUE part of code will delete entries of triangle to the right of where it "thinks" the diagonal is. 

ie it doesn't correctly identify diagonal when triangle has more rows than columns
    @00mathieu
    00mathieu committed May 21, 2015
    Configuration menu
    Copy the full SHA
    8f54e93 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2015

  1. Update BootstrapReserve.R 

    changed the check of whether nrow is greater than ncol from != to <. Without this, BootChainLadder will stop if the triangle doesn't have the same nrow as ncol. Condition should be that nrow <= ncol.
    @00mathieu
    00mathieu committed May 22, 2015
    Configuration menu
    Copy the full SHA
    1309844 View commit details
    Browse the repository at this point in the history
Loading